Improve: Moved the e2e password request to an alert instead of a popup#12172
Merged
Improve: Moved the e2e password request to an alert instead of a popup#12172
Conversation
…et.Chat into e2e-option-to-change-key
rodrigok
reviewed
Sep 26, 2018
|
|
||
| showAlert = () => { | ||
| alerts.open({ | ||
| title: TAPi18n.__('E2E_password'), |
Member
There was a problem hiding this comment.
I'd say a better title is Enter your encryption password
And the text To access your encrypted private groups and direct messages, insert your encryption key should be To access your encrypted private groups and direct messages, insert your encryption password
Contributor
There was a problem hiding this comment.
What about keeping it more in line with the title?
“Enter your encryption password to access your encrypted private groups and direct messages”?
The “.. insert your ...” part sounds weird to me ^^’
…request-to-alert # Conflicts: # packages/rocketchat-e2e/client/accountEncryption.html # packages/rocketchat-e2e/client/accountEncryption.js # packages/rocketchat-i18n/i18n/en.i18n.json
rodrigok
approved these changes
Sep 26, 2018
rodrigok
changed the title
rodrigok
changed the title
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #ISSUE_NUMBER