[FIX] Fixed SlackBridge Private Channels#12213
Closed
Ismaw34 wants to merge 6 commits intoRocketChat:developfrom
Ismaw34:develop
Closed
[FIX] Fixed SlackBridge Private Channels#12213Ismaw34 wants to merge 6 commits intoRocketChat:developfrom Ismaw34:develop
Ismaw34 wants to merge 6 commits intoRocketChat:developfrom
Ismaw34:develop
Conversation
|
Note: See #13261 for more details. That PR probably does not fix this issue - what we were seeing was slightly different than what was reported here. |
Contributor
|
Fixed on #14273 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11485
Maybe closes others
Slack Api changed the way that the channels were accessed, now the private channels must be accessed with other api calls and with args.
The bug was:
Slack to RocketChat: Works, private or public channels.
RocketChat to Slack: No message was sent if the Slack channel was private. Public channels are OK.