Skip to content

[FIX] Fix bug when user try recreate channel or group with same name and remove room from cache when user leaves room#12341

Merged
rodrigok merged 8 commits intodevelopfrom
fix-recreate-channels-with-same-name
Jan 29, 2019
Merged

[FIX] Fix bug when user try recreate channel or group with same name and remove room from cache when user leaves room#12341
rodrigok merged 8 commits intodevelopfrom
fix-recreate-channels-with-same-name

Conversation

@MarcosSpessatto
Copy link
Contributor

Closes #12013
Closes #12059
Closes #11897

@MarcosSpessatto MarcosSpessatto added this to the 0.71.0 milestone Oct 16, 2018
@MarcosSpessatto MarcosSpessatto self-assigned this Oct 16, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-12341 October 16, 2018 19:18 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-12341 October 22, 2018 20:07 Inactive
@rodrigok rodrigok modified the milestones: 0.71.0, 0.72.0 Nov 1, 2018
@MarcosSpessatto MarcosSpessatto changed the title [FIX] Fix bug when user try recreate channel or group with same name [WIP][FIX] Fix bug when user try recreate channel or group with same name Nov 6, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-12341 November 6, 2018 22:34 Inactive
@MarcosSpessatto MarcosSpessatto changed the title [WIP][FIX] Fix bug when user try recreate channel or group with same name [FIX] Fix bug when user try recreate channel or group with same name Nov 6, 2018
@MarcosSpessatto MarcosSpessatto changed the title [FIX] Fix bug when user try recreate channel or group with same name [FIX] Fix bug when user try recreate channel or group with same name and remove room from cache when user leaves room Nov 6, 2018
@geekgonecrazy
Copy link
Contributor

We should probably get this one in. This is one of those weird bugs that has effected people for a while. Way more then have commented or opened issues

@theorenck theorenck modified the milestones: 0.72.0, Short-term Dec 12, 2018
@MarcosSpessatto MarcosSpessatto modified the milestones: Short-term, 0.73.0 Dec 20, 2018
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-12341 December 20, 2018 23:56 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-12341 January 14, 2019 19:26 Inactive
@MarcosSpessatto MarcosSpessatto modified the milestones: 0.73.0, 0.74.0 Jan 14, 2019
Copy link
Member

@rodrigok rodrigok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need fix on the conflicts

@MarcosSpessatto
Copy link
Contributor Author

@rodrigok done

@rodrigok rodrigok modified the milestones: 0.74.0, 0.74.1 Jan 29, 2019
@rodrigok rodrigok merged commit c420a28 into develop Jan 29, 2019
@rodrigok rodrigok deleted the fix-recreate-channels-with-same-name branch January 29, 2019 20:23
sampaiodiego pushed a commit that referenced this pull request Feb 1, 2019
…and remove room from cache when user leaves room (#12341)

* Fix bug when user try recreate channel or group with same name

* Remove flowrouter from cachedcollection

* Remove room from cache when user leaves room

* Fix deletions and leaves from rooms in client, and rooms stream when delete room
@sampaiodiego sampaiodiego mentioned this pull request Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments