[IMPROVE] Add decoding for commonName (cn) and displayName attributes for SAML#12347
[IMPROVE] Add decoding for commonName (cn) and displayName attributes for SAML#12347sampaiodiego merged 16 commits intoRocketChat:developfrom pkolmann:develop
Conversation
Add displayName as a possibility for the name of the new user
|
Rocket Chat seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
I have signed the CLA already but it still shows as unsigned :( Can anyone suggest any solutions? Thanks |
|
@MarcosSpessatto could you please review my changes and help me get them merged. Thanks |
|
@Hudell do you have any hint for me, if this change could be merged? |
|
@pkolmann can you fix the conflicts? |
|
@rodrigok I fear I f*ed up my branch again... :( I have an updated patch that applies cleanly to 0.73.1. Can you use this as well? Maybe someone can tell me, where I did the update of my branch wrong: |
|
You should use the |
|
@Hudell thanks for the hint. I managed now to get everything uptodate. Now you should be able to pull. |
|
@rodrigok the branch is now in sync and can be merged. Thanks |
|
@sampaiodiego can you review and merge this? |
I want to create users via SAML. Currently the SAML IDP sends the Attributes urn:oid-encoded. This patch adds the decoding for commonName (cn) and displayName attributes.
Secondly it adds the displayName as a possibility for the name of the new user.