[FIX] Wrong permalink when running RocketChat in subdir#12721
Closed
ura14h wants to merge 9 commits intoRocketChat:developfrom
Closed
[FIX] Wrong permalink when running RocketChat in subdir#12721ura14h wants to merge 9 commits intoRocketChat:developfrom
ura14h wants to merge 9 commits intoRocketChat:developfrom
Conversation
# Conflicts: # packages/rocketchat-lib/lib/RoomTypesCommon.js # # Resolved: # Moved my patch in packages/rocketchat-lib/lib/RoomTypesCommon.js to packages/rocketchat-utils/lib/RoomTypesCommon.js.
Contributor
Author
|
@sampaiodiego @tassoevan Should I re-do a pull request on the new branch because I can not solve the error? |
Contributor
|
@ura14h Weird that you can't push to your own branch... 🤔 But, yeah, feel free to close this PR and open a new one; please mention me or @sampaiodiego. |
Contributor
Author
|
@sampaiodiego @tassoevan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11922