[IMPROVE] Don't show unread count badge in burger menu if it is from the opened room#12971
Merged
[IMPROVE] Don't show unread count badge in burger menu if it is from the opened room#12971
Conversation
engelgabriel
previously requested changes
Mar 11, 2019
Member
engelgabriel
left a comment
engelgabriel
left a comment
There was a problem hiding this comment.
Do we really want to add all this complexity? Shouldn't the badge disapear when you flag the room as read?
Contributor
Author
|
@engelgabriel As far I've understood #1285, we should discount unread messages from the opened room to achieve the desired behavior. If that's not a characteristic wanted for the unread messages counter, we must close both this PR and label #1285 as |
ggazzo
previously approved these changes
Mar 12, 2019
Member
|
@tassoevan can you fix the conflicts? |
…unread-indicator-mobile
ggazzo
approved these changes
May 16, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1285