[FIX] Change webdav creation, due to changes in the npm lib after last update#13170
Merged
[FIX] Change webdav creation, due to changes in the npm lib after last update#13170
Conversation
rodrigok
approved these changes
Jan 16, 2019
alansikora
pushed a commit
that referenced
this pull request
Jan 23, 2019
…t update (#13170) * Change webdav creation, due to changes in the npm lib after last update * Fix webdav in file-upload
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13093
Closes #13079
As we can see, the webdav lib we are using, after the last updates, from 1.x version to 2.x changes some functions, causing the errors related in the issue.
1.x index.js
2.x index.js
1.x createClient function
2.x createClient function