[NEW] Limit all DDP/Websocket requests (configurable via admin panel)#13311
Merged
sampaiodiego merged 5 commits intodevelopfrom Feb 1, 2019
Merged
[NEW] Limit all DDP/Websocket requests (configurable via admin panel)#13311sampaiodiego merged 5 commits intodevelopfrom
sampaiodiego merged 5 commits intodevelopfrom
Conversation
sampaiodiego
reviewed
Feb 1, 2019
|
|
||
| const callback = (message) => (reply, input) => { | ||
| if (reply.allowed === false) { | ||
| console.warn('DDP RATE LIMIT:', message); |
Member
There was a problem hiding this comment.
should we send this to Logger?
Member
Author
There was a problem hiding this comment.
We don't have a level for warnings in Logger, do you think this message should be an error?
Member
There was a problem hiding this comment.
it might be an error, since the client's request was denied.
I was initially thinking if this warns could flood the server's log, with no way to hide them.
Member
Author
There was a problem hiding this comment.
@sampaiodiego but there is no way to hide errors as well 😄
| }; | ||
|
|
||
| const matchedRules = self._findAllMatchingRules(input); | ||
| _.each(matchedRules, function(rule) { |
Member
Author
There was a problem hiding this comment.
I was keeping the meteor's code as much as possible
sampaiodiego
previously approved these changes
Feb 1, 2019
sampaiodiego
approved these changes
Feb 1, 2019
sampaiodiego
pushed a commit
that referenced
this pull request
Feb 1, 2019
Merged
engelgabriel
added a commit
that referenced
this pull request
Feb 3, 2019
* develop: [NEW] Limit all DDP/Websocket requests (configurable via admin panel) (#13311) [FIX] Mobile view and re-enable E2E tests (#13322) [NEW] REST endpoint to forward livechat rooms (#13308) [FIX] Hipchat Enterprise Importer not generating subscriptions (#13293) [FIX] Message updating by Apps (#13294) [FIX] REST endpoint for creating custom emojis (#13306) [FIX] Preview of image uploads were not working when apps framework is enable (#13303)
Montel
pushed a commit
to Montel/Rocket.Chat
that referenced
this pull request
Feb 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.