[NEW] Add missing remove add leader channel#13315
Merged
MarcosSpessatto merged 6 commits intoRocketChat:developfrom Feb 18, 2019
Merged
[NEW] Add missing remove add leader channel#13315MarcosSpessatto merged 6 commits intoRocketChat:developfrom
MarcosSpessatto merged 6 commits intoRocketChat:developfrom
Conversation
Add removeLeader/addLeader
Contributor
|
@Montel can you please add these endpoint to the |
Contributor
Author
|
it's already implemented :) |
Contributor
Author
|
groups.addLeader and groups.removeLeader is already implemented. |
Contributor
|
Oh, you're right. I'll implement some tests for these endpoints, or you can take care of this? |
Contributor
Author
|
Please do it :) You know better it as me :) Thanks |
Contributor
Author
|
(Another request #13334 it's about typo in command name, I don't know how to add requester). Regards |
MarcosSpessatto
previously approved these changes
Feb 11, 2019
MarcosSpessatto
changed the title
Contributor
Author
|
I created this one #13445 (I hope that it's ok now :) ) |
MarcosSpessatto
approved these changes
Feb 18, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13315