Skip to content

[FIX] Setup wizard calling 'saveSetting' for each field/setting#13349

Merged
rodrigok merged 1 commit intodevelopfrom
fix-batch
Feb 5, 2019
Merged

[FIX] Setup wizard calling 'saveSetting' for each field/setting#13349
rodrigok merged 1 commit intodevelopfrom
fix-batch

Conversation

@ggazzo
Copy link
Member

@ggazzo ggazzo commented Feb 4, 2019

the old method was calling multiple times saveSetting, now we have one saveSettings, that you can pass all settings in a row.

Closes #13329

@ggazzo ggazzo requested a review from rodrigok February 4, 2019 22:16
@ggazzo ggazzo changed the title [FIX] Settings. batchSet [FIX] Settings.batchSet Feb 4, 2019
@rodrigok rodrigok added this to the 0.74.2 milestone Feb 5, 2019
@rodrigok rodrigok changed the title [FIX] Settings.batchSet [FIX] Settings saving was being called multiple times and being denied by Rate Limiter in some cases Feb 5, 2019
@rodrigok rodrigok merged commit 5297f3d into develop Feb 5, 2019
@rodrigok rodrigok deleted the fix-batch branch February 5, 2019 16:12
@ggazzo ggazzo changed the title [FIX] Settings saving was being called multiple times and being denied by Rate Limiter in some cases [FIX] Settings saving were being called multiple times and being denied by Rate Limiter in some cases Feb 5, 2019
@ggazzo ggazzo changed the title [FIX] Settings saving were being called multiple times and being denied by Rate Limiter in some cases [FIX] Setup wizard calling 'saveSetting' for each one Feb 5, 2019
@ggazzo ggazzo changed the title [FIX] Setup wizard calling 'saveSetting' for each one [FIX] Setup wizard calling 'saveSetting' for each field/setting Feb 5, 2019
sampaiodiego pushed a commit that referenced this pull request Feb 5, 2019
@sampaiodiego sampaiodiego mentioned this pull request Feb 5, 2019
Montel pushed a commit to Montel/Rocket.Chat that referenced this pull request Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments