[IMPROVE] Update to MongoDB 4.0 in docker-compose file#13396
Merged
sampaiodiego merged 2 commits intoRocketChat:developfrom Feb 8, 2019
Merged
[IMPROVE] Update to MongoDB 4.0 in docker-compose file#13396sampaiodiego merged 2 commits intoRocketChat:developfrom
sampaiodiego merged 2 commits intoRocketChat:developfrom
Conversation
sampaiodiego
requested changes
Feb 8, 2019
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
thanks @ngulden .. but we still support Mongo 3.2 (we have tests on CI to make sure it works) even though I would recommend going with Mongo 4.0 now, I think we should recommend that on compose file instead.
docker-compose.yml
Outdated
|
|
||
| mongo: | ||
| image: mongo:3.2 | ||
| image: mongo:3.6 |
Member
There was a problem hiding this comment.
can you change to Mongo 4.0? see review message.
Contributor
Author
There was a problem hiding this comment.
Done. See latest commit.
The current recommendation of Rocket.Chat is MongoDB 3.6.
ngulden
force-pushed
the
ngulden/update-mongodb-version
branch
from
965c408 to
ad83d9e
Compare
sampaiodiego
changed the title
sampaiodiego
approved these changes
Feb 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current recommendation of Rocket.Chat is MongoDB 3.6.
Initializing a Docker Compose Setup with MongoDB 3.2 would require a step by step upgrade via MongoDB 3.4. See the release notes of Mongo DB:
This can be skipped by just using a more recent version of MongoDB.