Skip to content

[FIX] Small improvements on message box#13444

Merged
ggazzo merged 14 commits intodevelopfrom
fix/message-box
Feb 13, 2019
Merged

[FIX] Small improvements on message box#13444
ggazzo merged 14 commits intodevelopfrom
fix/message-box

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Feb 11, 2019

  • Remove outdated helpers, events, and CSS rules
  • Update styles for read-only room and unsubscribed room
  • Isolate startup code from template
  • Split messageBox template into smaller ones
  • Rename "markdown buttons" to "formatting buttons"
  • Autofocus only in desktop
  • Update autogrow shadow ASAP on focus event

@tassoevan tassoevan added area: ui Touches the code on client side type: improvement labels Feb 11, 2019
@tassoevan tassoevan added this to the 0.75.0 milestone Feb 11, 2019
@tassoevan tassoevan self-assigned this Feb 11, 2019
@tassoevan tassoevan requested review from ggazzo and rodrigok February 11, 2019 23:17
ggazzo
ggazzo previously approved these changes Feb 12, 2019
View reviewed changes
@ggazzo ggazzo merged commit db5f773 into develop Feb 13, 2019
@ggazzo ggazzo deleted the fix/message-box branch February 13, 2019 00:47
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggazzo ggazzo ggazzo left review comments

@rodrigok rodrigok Awaiting requested review from rodrigok

Assignees

@tassoevan tassoevan

Labels

area: ui Touches the code on client side type: improvement

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@tassoevan @ggazzo @engelgabriel

Comments