[FIX] Emoji detection at line breaks#13447
Merged
sampaiodiego merged 6 commits intoRocketChat:developfrom Feb 14, 2019
savish28:Issue-#13059-Emoji-detection-linebreak
Merged
[FIX] Emoji detection at line breaks#13447sampaiodiego merged 6 commits intoRocketChat:developfrom savish28:Issue-#13059-Emoji-detection-linebreak
sampaiodiego merged 6 commits intoRocketChat:developfrom
savish28:Issue-#13059-Emoji-detection-linebreak
Conversation
tassoevan
approved these changes
Feb 12, 2019
sampaiodiego
approved these changes
Feb 14, 2019
sampaiodiego
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13059
Initially emojis at linebreaks were not detected.
This PR solves the issue and now it looks like:
Input given in both the cases:
:D foo :D bar :D baz :D quux :D
:D this :D is :D a simple :D test :D
without :D leading :D or :D trailing :D emote
:D hello :D world :D
(contains no trailing or leading whitespace)