[FIX] Non-latin room names and other slugifications#13467
Merged
Conversation
tassoevan
changed the title
MarcosSpessatto
previously approved these changes
Feb 27, 2019
sampaiodiego
requested changes
Feb 28, 2019
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
in some places the limax module is being imported as slug and in another ones as limax, can you please normalize that?
sampaiodiego
approved these changes
Mar 1, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13296
@sampaiodiego, I made this as WIP because there are more locations where some form of slugification is done, via
underscore.stringand a Meteor package.