Skip to content

[FIX] Typo in a referrer header in inject.js file#13469

Merged
ggazzo merged 4 commits intoRocketChat:developfrom
algomaster99:fixtypo/referrer-header-inject.js
Mar 1, 2019
Merged

[FIX] Typo in a referrer header in inject.js file#13469
ggazzo merged 4 commits intoRocketChat:developfrom
algomaster99:fixtypo/referrer-header-inject.js

Conversation

@algomaster99
Copy link
Contributor

  • [FIX] Typo in a referrer header in inject.js file

  • [FIX] Meta tag is a self closing tag. Added a slash at the end just to stay in accordance with conventions

Closes #13466

Changes just fix a minor typo. A header directive called origin-when-cross-origin was not written correctly. Reference: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Referrer-Policy#Directives.

@CLAassistant
Copy link

CLAassistant commented Feb 13, 2019

CLA assistant check
All committers have signed the CLA.

@ggazzo ggazzo added this to the 0.75.0 milestone Feb 13, 2019
@ggazzo
Copy link
Member

ggazzo commented Feb 13, 2019

@algomaster99 could you sing the CLA ?

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@algomaster99
Copy link
Contributor Author

@ggazzo I have signed it but it still doesn't show.

@ggazzo ggazzo merged commit 576c38a into RocketChat:develop Mar 1, 2019
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

origin-when-crossorigin should be origin-when-cross-origin

3 participants

Comments