[FIX] Race condition on the loading of Apps on the admin page#13587
Merged
[FIX] Race condition on the loading of Apps on the admin page#13587
Conversation
sampaiodiego
requested changes
Mar 11, 2019
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
this current adds a new buggy behavior, if you change to "installed" while "marketplace" is still loading, it shows the loading dots on the bottom
Member
|
@graywolf336 I've made a few changes to fix the issue I mentioned earlier.. see 1f28e4f .. |
ggazzo
previously approved these changes
Mar 11, 2019
ggazzo
approved these changes
Mar 11, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where if you select the
InstalledApps tab before the loading of the Marketplace Apps finished, the marketplace apps would be displayed when it finished loading.