Skip to content

[IMPROVE] Deprecate fixCordova helper#13598

Merged
rodrigok merged 2 commits intodevelopfrom
improve/remove-legacy-cordova-helper
Mar 2, 2019
Merged

[IMPROVE] Deprecate fixCordova helper#13598
rodrigok merged 2 commits intodevelopfrom
improve/remove-legacy-cordova-helper

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Mar 1, 2019

🌆
closes #11924

@tassoevan tassoevan added area: ui Touches the code on client side type: improvement labels Mar 1, 2019
@tassoevan tassoevan added this to the 1.0.0 milestone Mar 1, 2019
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13598 March 1, 2019 21:04 Inactive
@ura14h
Copy link
Contributor

ura14h commented Mar 2, 2019

If fixCordova helper is deleted, please also check #11924 .

@rodrigok
Copy link
Member

rodrigok commented Mar 2, 2019

@ura14h this PR will solve the issue you mentioned. Thanks

@rodrigok rodrigok mentioned this pull request Mar 2, 2019
@rodrigok rodrigok merged commit 2e9b0ff into develop Mar 2, 2019
@rodrigok rodrigok deleted the improve/remove-legacy-cordova-helper branch March 2, 2019 20:56
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui Touches the code on client side type: improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

channel avatar is not shown when Rocket.Chat is running in subdir

4 participants

Comments