[FIX] Adds css styling to the cmsPage.html#13626
Closed
fliptrail wants to merge 5 commits intoRocketChat:developfrom
fliptrail:cms-page-edit
Closed
[FIX] Adds css styling to the cmsPage.html#13626fliptrail wants to merge 5 commits intoRocketChat:developfrom fliptrail:cms-page-edit
fliptrail wants to merge 5 commits intoRocketChat:developfrom
fliptrail:cms-page-edit
Conversation
Makes it look more user friendly
|
It Looks decent but you could add more space between the last 2 lines and improve a bit of styling so issue hopefully would be closed. Though, it's just my opinion. |
Contributor
Author
|
Problem with that is that the text coming from server is not marked up properly. There's a brute force method. Will try to use it. |
Contributor
Author
|
Added more commits and improved the final status |
Contributor
Author
|
Please review this PR |
Contributor
Author
|
@tassoevan @wreiske Please review this. |
Member
|
@fliptrail sorry but you deleted your branch I cant push any fix, and I dont think its good enough... sorry... |
Contributor
Author
|
I will try again better next time. Actually this was one of my first PR's on this repo and I was actually trying to understand the repo structure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the Terms of Condition page and the Privacy Policy page more attractive to the user.
Closes #13577
Initial State:
Final State:
Updated the CSS styling like this so that headings and text are clearly visible. Also added margins and padding to the whole container.
