[FIX] Elements in User Info require some padding#13640
Merged
ggazzo merged 6 commits intoRocketChat:developfrom May 16, 2019
mushroomgenie:develop
Merged
[FIX] Elements in User Info require some padding#13640ggazzo merged 6 commits intoRocketChat:developfrom mushroomgenie:develop
ggazzo merged 6 commits intoRocketChat:developfrom
mushroomgenie:develop
Conversation
|
|
Contributor
|
@mushroomgenie I guess package-lock.json should remain unchanged. @knrt10 What's your call? |
Contributor
|
yes @fliptrail you are right. @mushroomgenie when you run |
Contributor
Author
|
@fliptrail and @knrt10 Sorry I must have missed that step while committing.I'll revert the commits and then push to the PR. |
ggazzo
previously approved these changes
Mar 14, 2019
Member
|
@mushroomgenie please fix the conflicts (: |
Contributor
Author
|
@ggazzo Can you review the changes ? |
ggazzo
approved these changes
May 16, 2019
ggazzo
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13638
Before
After