[IMPROVE] Filter agents with autocomplete input instead of select element#13730
Merged
[IMPROVE] Filter agents with autocomplete input instead of select element#13730
Conversation
…arch # Conflicts: # app/livechat/client/views/app/livechatCurrentChats.js
ggazzo
requested changes
Mar 19, 2019
Member
ggazzo
left a comment
ggazzo
left a comment
There was a problem hiding this comment.
what do you think about use the new templates and update the select to rc-select ?
Author
Cool! I'll take a look at this now. |
ggazzo
force-pushed
the
replace-agents-select-by-auto-complete-search
branch
from
9d77c37 to
de18de1
Compare
ggazzo
approved these changes
Mar 22, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13728
Everything is working fine with the new components: autocomplete and
rc-select:But there is a fix needed related to alignment of the components:
@ggazzo, can you please take a look at this?
Thanks.