[IMPROVE] Join channels by sending a message or join button (#13752)#13752
Merged
ggazzo merged 34 commits intoRocketChat:developfrom Mar 22, 2019
Merged
[IMPROVE] Join channels by sending a message or join button (#13752)#13752ggazzo merged 34 commits intoRocketChat:developfrom
ggazzo merged 34 commits intoRocketChat:developfrom
Conversation
knrt10
suggested changes
Mar 17, 2019
app/lib/lib/roomTypes/private.js
Outdated
| @@ -71,9 +71,6 @@ export class PrivateRoomType extends RoomTypeConfig { | |||
|
|
|||
| canSendMessage(roomId) { | |||
| const room = ChatRoom.findOne({ _id: roomId, t: 'p' }, { fields: { prid: 1 } }); | |||
Contributor
There was a problem hiding this comment.
Hey, room is never used, you should delete it. That's the reason your CI is failing.
| @@ -11,17 +11,17 @@ import './messageBoxNotSubscribed.html'; | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Similarly, most of the imported things are imported RoomHistoryManager, RoomManager, t, hasAllPermission, toastr but not used, you should remove them. These all are on line 5,6,7,8
…ads-system-messages
…t.Chat into threads-system-messages
…t.Chat into pr/13752-bhardwajaditya-roomjoin
… pr/13752-bhardwajaditya-roomjoin
ggazzo
previously approved these changes
Mar 22, 2019
ggazzo
approved these changes
Mar 22, 2019
ggazzo
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users can join new channels/threads using join button or sending a text message.
@ggazzo @thiagosanchz please review
Join with button join
Join with text message