Skip to content

[NEW] Marketplace integration with Rocket.Chat Cloud#13774

Closed
graywolf336 wants to merge 7 commits intodevelopfrom
marketplace-and-cloud
Closed

[NEW] Marketplace integration with Rocket.Chat Cloud#13774
graywolf336 wants to merge 7 commits intodevelopfrom
marketplace-and-cloud

Conversation

@graywolf336
Copy link
Contributor

Work in progress of the integration with marketplace and cloud, allowing purchasing apps. :)

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13774 March 18, 2019 18:45 Inactive
@rodrigok
Copy link
Member

@graywolf336 can you sync with develop moving the changes from package to folder app?

@rodrigok
Copy link
Member

When click to by and cancel the spinner keeps running

@graywolf336
Copy link
Contributor Author

Notice there's a todo comment in the code? ;) it does need to be fixed and the code says so lol

@rodrigok
Copy link
Member

The install inside app's details does not open the iframe to confirm

@rodrigok
Copy link
Member

@graywolf336 I didn't review the code, I'm reviewing the functionality.
If it's not complete please add [WIP] at the beginning of the PR's title and list the pending items because if Gabriel or the UX team will review the PR they will not read the code!

@rodrigok
Copy link
Member

When bying an app the button get for free doesn't works generating the error:
image

@graywolf336
Copy link
Contributor Author

It's a draft pull request, which is used to indicate that it is a draft and not fully ready. There is absolutely still a lot of work to do, a large portion of which I have knocked out and have already addressed.

@graywolf336
Copy link
Contributor Author

This pull request was not intended to be review ready but was simply to show the current flow, of which the reason it was created in a draft status is because it is not working functionality wise.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13774 March 19, 2019 22:31 Inactive
@rodrigok
Copy link
Member

Continue the development on #13809

@rodrigok rodrigok closed this Mar 20, 2019
@graywolf336 graywolf336 deleted the marketplace-and-cloud branch March 20, 2019 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments