Skip to content

[FIX] Improve cloud section#13820

Merged
rodrigok merged 10 commits intodevelopfrom
improve-cloud-integration
Apr 2, 2019
Merged

[FIX] Improve cloud section#13820
rodrigok merged 10 commits intodevelopfrom
improve-cloud-integration

Conversation

@geekgonecrazy
Copy link
Contributor

@geekgonecrazy geekgonecrazy commented Mar 20, 2019

Improving cloud section to:

  • register directly instead of via stats collector
  • Allow updating of email address
  • Allow disconnecting/reconnect to cloud
  • Handle unregister gracefully

The connect screen has a note at the bottom with a link to support. If they click it will prefill the subject and body with info that will help us resolve any issues getting connected.

image

The page after connected takes to cloud console instead of oauth for now ( we weren't using it ). Has a sync button and a disconnect button. The sync button should help resolve some issues as well as force license refresh.

image

Disconnect disables everything. Unregistering happens from cloud console

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13820 March 20, 2019 20:38 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13820 March 20, 2019 23:15 Inactive
@geekgonecrazy geekgonecrazy marked this pull request as ready for review March 20, 2019 23:15
@geekgonecrazy geekgonecrazy added this to the 1.0.0 milestone Mar 20, 2019
@geekgonecrazy
Copy link
Contributor Author

Going to make a few more changes on this one including the ones above.

@sampaiodiego sampaiodiego temporarily deployed to rocket-chat-pr-13820 March 26, 2019 17:54 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13820 March 26, 2019 23:11 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13820 March 27, 2019 07:03 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13820 March 28, 2019 01:46 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13820 March 28, 2019 22:34 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13820 March 28, 2019 22:40 Inactive
@geekgonecrazy
Copy link
Contributor Author

alright done tweaking. Just had to get oauth scopes and change how the params were sent from url to the body.

@rodrigok rodrigok merged commit b0d71bc into develop Apr 2, 2019
@rodrigok rodrigok deleted the improve-cloud-integration branch April 2, 2019 16:16
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments