[FEATURE] Default filter on Opened Chats only for window "Current Chats" on Livechat#13848
[FEATURE] Default filter on Opened Chats only for window "Current Chats" on Livechat#13848knrt10 wants to merge 7 commits intoRocketChat:developfrom
Conversation
knrt10
changed the title
|
Please save the user's option on localStorage. |
|
Ok, let me update |
knrt10
force-pushed
the
issue12703
branch
3 times, most recently
from
caf49c7 to
9a03e10
Compare
|
Hi @knrt10 Thanks. |
|
@renatobecker fixed. Please review |
Can you please fix the conflicts? |
Signed-off-by: knrt10 <tripathi.kautilya@gmail.com>
Signed-off-by: knrt10 <tripathi.kautilya@gmail.com>
|
@renatobecker fixed. |
| return this.servedBy && this.servedBy.username; | ||
| }, | ||
| status() { | ||
| if (localStorage.getItem('status')) { |
There was a problem hiding this comment.
Why are you returning the localstorage value here? It's a helper to translate the status of each room rendered
| format: moment.localeData().longDateFormat('L').toLowerCase(), | ||
| }); | ||
|
|
||
| // Set value of select |
There was a problem hiding this comment.
Should use a helper to return the value to the template instead of set it manually
| this.tagFilters = new ReactiveVar([]); | ||
| this.departments = new ReactiveVar([]); | ||
|
|
||
| if (localStorage.getItem('status')) { |
There was a problem hiding this comment.
Prevent code duplicationg by moving the getItem from localstorage to a variable.
Use a better name than just status, it's too generic and may be used by another place in the application. Use some thing like livechatCurrentChats.filter.status
|
|
|
Hey @knrt10, there are new conflicts, sry. for not reviewing it before. |
9 participants
Closes #12703
cc @renatobecker would you please review.