[FIX] Display first message when taking Livechat inquiry#13896
Merged
sampaiodiego merged 11 commits intodevelopfrom Apr 2, 2019
Merged
[FIX] Display first message when taking Livechat inquiry#13896sampaiodiego merged 11 commits intodevelopfrom
sampaiodiego merged 11 commits intodevelopfrom
Conversation
tassoevan
requested changes
Mar 25, 2019
tassoevan
previously approved these changes
Mar 26, 2019
sampaiodiego
requested changes
Mar 26, 2019
…RocketChat/Rocket.Chat into livechat-get-first-room-message
sampaiodiego
requested changes
Mar 29, 2019
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
should it be fixed the other way around? like, fix by adding the message on the inquiry again?
what happened to that code? is it obsolete now? should it be removed then?
Author
The new livechat gets the |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13668.
Since the new Livechat client gets a new room before sending messages, this change has impacted on the
Guest Poolrouting method because now the first message is no longer stored into theInquirycollection.Due to that, now the
Take Inquirydialog will retrieve the first message by calling a server-side method.