[BREAK] Prevent start if incompatible mongo version#13927
Merged
Conversation
sampaiodiego
reviewed
Apr 2, 2019
| msg += ['', '', 'YOUR CURRENT NODEJS VERSION IS NOT SUPPORTED,', `PLEASE UPGRADE / DOWNGRADE TO VERSION ${ desiredNodeVersionMajor }.X.X`].join('\n'); | ||
| SystemLogger.error_box(msg, 'SERVER ERROR'); | ||
|
|
||
| return process.exit(); |
Member
There was a problem hiding this comment.
should we call this as [BREAK] because of this? like, people will need to know before hand if they upgrade and are using a not desired node or mongo version the server will not start.
Contributor
Author
There was a problem hiding this comment.
I’ll change title. I think that’s fair. But it actually wouldn’t work anyways before it was leading to tickets open.
Better to do this as a breaking change now with 1.0 then after
geekgonecrazy
changed the title
rodrigok
approved these changes
Apr 3, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought about showing an alert.. but i'm not sure how we are injecting .node_version.txt or i'd try to do the same for mongodb.
I thought about hard coding
^3.2.0but meteor cli doesn't even ship with that yet 🤦♂️