[FIX] Limit App’s HTTP calls to 500ms#13949
Merged
sampaiodiego merged 3 commits intodevelopfrom Apr 1, 2019
Merged
Conversation
And fix a regresion
sampaiodiego
requested changes
Mar 29, 2019
|
|
||
| async call(info) { | ||
| if (typeof info.request.timeout !== 'number' || info.request.timeout > 500) { | ||
| info.request.timeout = 500; |
Member
There was a problem hiding this comment.
I'm not sure 500 is a good number. Wondering how many requests may start failing after adding this timeout.
also because of this I think we should tag as a break change.
Member
Author
There was a problem hiding this comment.
The VM has a timeout of 1000ms, that's why 500ms.
I think it's more a fix than a break change, since the HTTP not respecting the VM's timeout wasn't expected.
Co-Authored-By: rodrigok <rodrigoknascimento@gmail.com>
Contributor
|
What happens when this timeout is reached? Will it reject the promise of silently fail? |
Member
Author
|
@graywolf336 it will reject the promise and return the response as timeout |
Member
|
I would say that it would be valuable to add some tests for this case.... but since we are so interested on merging this ASAP, I'll just say LGTM 🙈 |
sampaiodiego
changed the title
sampaiodiego
approved these changes
Apr 1, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And fix a regression