[IMPROVE] Remove setting to show a livechat is waiting

[renatobecker-zz]

Related to -> RocketChat/Rocket.Chat.Livechat#210.

We decided to remove the "Livechat_open_inquiery_show_connecting" setting that was used to prevent livechat users from sending messages while they were waiting in the queue.
Now, if the routing method = 'Guest Pool', the livechat users will be able to send messages even when they are waiting for an available agent.

On the new client, an alert will be displayed, notifying the users that they are waiting in the queue.

[sampaiodiego]

the default value is already false, I don't get why remove it..

just remembering this is added by @AlecTroemel in #4572 I wonder what was his use case for it.

[AlecTroemel]

I believe my intent was to inform the client they were "in the pool", ie waiting to connect to an agent. Otherwise, they could assume they were connected to somebody, start sending messages and get frustrated with no response. I think the clients status in the pool should be communicated to them is some way... though I don't use the live chat feature of rocket chat anymore so it's just my 2 cents. Hope that helps!

[renatobecker-zz]

the default value is already false, I don't get why remove it..

@engelgabriel required to remove the setting since it will not be used anymore..

[renatobecker-zz]

Here's how the widget will look when waiting for an available agent:

[sampaiodiego]

can you please write a migration to remove the setting Livechat_open_inquiery_show_connecting as well?

please remove the i18n key too.

@renatobecker how will it look on the old client? since it is still the default, I think it should have some status as you showed for the new client.

[renatobecker-zz]

can you please write a migration to remove the setting Livechat_open_inquiery_show_connecting as well?

please remove the i18n key too.

@renatobecker how will it look on the old client? since it is still the default, I think it should have some status as you showed for the new client.

Okay, I'll create a migration to remove the deprecated setting, as well as removing the i18n keys..
Regarding the old client, I'll add some alert as we do on the new client.

[renatobecker-zz]

@sampaiodiego,

I Just pushed the code adding an alert when the guest is waiting for an available agent, as displayed below(Old livechat version):

[rasos]

There is a typo in the german translation, I corrected it in Lingohub but can't find that term in de.i18n.json

"Please_wait_for_the_next_available_agent": "Bitte auf die nächste freie Beratung warten",

I also tried to apply a manual translation but it seems the livechat gets his translations from somewhere else?

[sampaiodiego]

thanks @rasos .. the new livechat widget has its own translation string at https://github.com/RocketChat/Rocket.Chat.Livechat

we should be creating a lingohub project for it soon.

[rasos]

Ah I see, the translations in the Livechat 2.0 project seem okay.

However we may be keeping the 1.0 widget for a while, we prefer the bar and not the icon. Any hints where to find that? github does not know e.g. Please_wait_for_the_next_available_agent in any RocketChat project and it seems not to be taken from Lingohub.