Regression: Discussions were not showing on Tab Bar#14050
Merged
rodrigok merged 4 commits intoRocketChat:developfrom Apr 27, 2019
Merged
Regression: Discussions were not showing on Tab Bar#14050rodrigok merged 4 commits intoRocketChat:developfrom
rodrigok merged 4 commits intoRocketChat:developfrom
Conversation
knrt10
force-pushed
the
issue14040
branch
3 times, most recently
from
4e3ed13 to
d8edbfa
Compare
ggazzo
previously requested changes
Apr 8, 2019
Contributor
Author
|
@ggazzo updated the PR with cursors. |
tassoevan
added
feat: threads / discussions
tassoevan
changed the title
rodrigok
approved these changes
Apr 27, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem was that collection was initially not loading, so
count()function was not working. Another main problem was inTemplate.subscriptionsReadybeacause the subscription was no longer ready, so the whole template was being un-rendered and re-rendered, for a relatively small change that can be optimistically predicted. Fixed it nowCloses #14040
cc @tassoevan @ggazzo would you please review