[FIX] Support for handling SAML LogoutRequest SLO#14074
[FIX] Support for handling SAML LogoutRequest SLO#14074sampaiodiego merged 6 commits intodevelopfrom
Conversation
| '</samlp:LogoutRequest>'; | ||
|
|
||
| request = `${ '<samlp:LogoutRequest xmlns:samlp="urn:oasis:names:tc:SAML:2.0:protocol" ' + | ||
| const request = `${ '<samlp:LogoutRequest xmlns:samlp="urn:oasis:names:tc:SAML:2.0:protocol" ' + |
There was a problem hiding this comment.
I don't understand exactly why the initial one was being defined.. and then directly overwritten right below 🙈
|
I tested and both IDP and SP initiated logout work well with this patch! |
ghost
mentioned this pull request
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
as it only adds a new functionality (old code remains the same), I think it would be fine to merge. I have only few requests regarding code style =)
|
@geekgonecrazy I've changed the code a little bit to be even more flat.. that helped also to find situations where you can see the diff here without showing whitespace changes.. can you please test it again as I don't know how to do it? 😬 if still working, please feel free to merge it! |
|
@geekgonecrazy the test server is still available, can you update the instance using git pull or so? Then I am happy to test it some more. But I don't want to try and git pull it myself, and perhaps end up testing the wrong branch. |
|
@barrydegraaff still works as expected 👍 @sampaiodiego ah yes your changes look like they would return more often like it should in case of errors. 🤗 |
3 participants
Closes: #13562
SAML experts please let me know if something is missing?