Skip to content

Regression: Message box does not go back to initial state after sending a message#14161

Merged
rodrigok merged 3 commits intodevelopfrom
set-input-state-after-submit-message
Apr 17, 2019
Merged

Regression: Message box does not go back to initial state after sending a message#14161
rodrigok merged 3 commits intodevelopfrom
set-input-state-after-submit-message

Conversation

@rodrigok
Copy link
Member

@rodrigok rodrigok commented Apr 16, 2019

Closes #14105

@rodrigok rodrigok added this to the 1.0.0 milestone Apr 16, 2019
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-14161 April 16, 2019 20:46 Inactive
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-14161 April 17, 2019 13:33 Inactive
@tassoevan
Copy link
Contributor

tassoevan commented Apr 17, 2019

The keydown event listener wasn't the right place to alter. I parallelly did a fix, so I'm going to merge it here.

@rodrigok rodrigok merged commit 183652b into develop Apr 17, 2019
@rodrigok rodrigok deleted the set-input-state-after-submit-message branch April 17, 2019 18:36
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tassoevan tassoevan Awaiting requested review from tassoevan

@sampaiodiego sampaiodiego Awaiting requested review from sampaiodiego

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

Message box does not go back to initial state after sending a message

3 participants

@rodrigok @tassoevan @engelgabriel

Comments