Closed
Conversation
Member
|
@ggazzo can you split this in multiple PRs? |
Member
Author
|
do you really think we need create 4 prs for 10 |
Member
|
@ggazzo it's not due to the code changes, but the description of the changes, you are adding 4 fixes in a single change line in change log that means almost nothing. Would be much better if we have each of them listed in change logs and well described don't you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readded threads follow and unfollow Closes #14344
Allow change discussions properties #14027
fix edited messages for nrr disabled
should close #14158