[NEW] Custom user name field from Custom OAuth#14381
Merged
rodrigok merged 5 commits intoRocketChat:developfrom May 15, 2019
Merged
[NEW] Custom user name field from Custom OAuth#14381rodrigok merged 5 commits intoRocketChat:developfrom
rodrigok merged 5 commits intoRocketChat:developfrom
Conversation
Renamed field to be more intuitive Co-Authored-By: mjovanovic0 <milan@jovanovich.net>
geekgonecrazy
approved these changes
May 7, 2019
Contributor
|
I've gone ahead and approved, will likely merge after we get 1.0.3 out the door. Thanks! |
Merged
|
How about other custom field?
How can I do it with custom OAUTH profile? |
Member
|
We can add a mapping as we do on LDAP |
It would be nice! Some easy workaround for now? Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes RocketChat/feature-requests#107
In settings I added new property: Accounts_OAuth_Custom_Name_Field which holds information of field in custom OAuth identity response from which user name should be populated (ex.:
fullName)