[FIX] Downloading files when running in sub directory

[miolane]

fix URI for uploading file

Closes #14472

[CLAassistant]

All committers have signed the CLA.

[miolane]

Sorry for my previous stupid mistake.

[ura14h]

I feel it is better to create a link using getURL() at the time of display like app/ui-flextab/client/tabs/uploadedFilesList.js, not at upload time.

@tassoevan what do you think about?

[tassoevan]

@miolane, @ura14h is absolutely right; fixing the bug at the getURL() helper is the way to go.

[miolane]

@ura14h Thanks for your direction. I'm not familiar with the frameworks and the whole system and do it in a wrong way.

[miolane]

@tassoevan I found many wrong urls in this edge case. One of them is the footer of side navigator. I tried to change app/lib/server/startup/settings.js at line 1246 to

return this.add('Layout_Sidenav_Footer', `<a href=${ getURL('home') }>\<img src="assets/logo"/\></a>`, {
			type: 'code',
			code: 'text/html',
			public: true,
			i18nDescription: 'Layout_Sidenav_Footer_description',
		});

but it doesn't work

[ura14h]

@miolane Your insight is great.

However, I think it is difficult to solve as this pull-request because the scope is too large. This pull- request should be focused on only solving the upload and download link issues, for to merge easy.

You can report a new issue about other wrong links you found and create a new pull-request for to fix it.

Thanks.

[miolane]

@ura14h I have already solved the upload and download issue by using getURL() but it still tells me
"Changes requested". I don't how to let it be merged. Sorry I'm new in Github.

[ura14h]

I think that the reviewer will close "Changes requested" manually. So you need only to mention to tassoevan that "changed to using getURL()" after fixing the point where He and I pointed out.

Then after, reviewers reviews your changes again, and RocketChat development members approve and merge it into develop-branch.

[ura14h]

@tassoevan, I feel that 3455ad1 is good but 22b7848 is not necessary.