[NEW] Experimental Game Center (externalComponents implementation)#15123
Merged
sampaiodiego merged 120 commits intodevelopfrom Mar 19, 2020
Merged
[NEW] Experimental Game Center (externalComponents implementation)#15123sampaiodiego merged 120 commits intodevelopfrom
sampaiodiego merged 120 commits intodevelopfrom
Conversation
* in order to keep consistent with gameCenter.html
Apps engine.ui.extra component 1
d-gubert
commented
Aug 7, 2019
|
|
sampaiodiego
requested changes
Mar 17, 2020
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
I've requested a few small changes.. but the really important ones are related to the autocomplete changes we've made while this PR was open.
Co-Authored-By: Diego Sampaio <chinello@gmail.com>
Co-Authored-By: Diego Sampaio <chinello@gmail.com>
Co-Authored-By: Diego Sampaio <chinello@gmail.com>
…hat/Rocket.Chat into lolimay-apps-engine-experimental
sampaiodiego
requested changes
Mar 19, 2020
Co-Authored-By: Diego Sampaio <chinello@gmail.com>
Co-Authored-By: Diego Sampaio <chinello@gmail.com>
sampaiodiego
approved these changes
Mar 19, 2020
sampaiodiego
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of the experimental Game Center, showcasing the new ExternalComponents from the Apps-Engine
For the next iteration: