Skip to content

Comments

[Apps] Support multiple external components per app#15495

Merged
shiqimei merged 4 commits intoRocketChat:lolimay-apps-engine-experimentalfrom
shiqimei:support-multiple-external-components-per-app
Nov 11, 2019
Merged

[Apps] Support multiple external components per app#15495
shiqimei merged 4 commits intoRocketChat:lolimay-apps-engine-experimentalfrom
shiqimei:support-multiple-external-components-per-app

Conversation

@shiqimei
Copy link
Contributor

@shiqimei shiqimei commented Oct 3, 2019

* Rename providedExternalComponents to registeredExternalComponents
* use the same names to keep consistent with apps engine repo
@shiqimei shiqimei closed this Oct 18, 2019
@shiqimei shiqimei deleted the support-multiple-external-components-per-app branch October 18, 2019 18:25
@shiqimei shiqimei restored the support-multiple-external-components-per-app branch October 19, 2019 12:34
@shiqimei shiqimei changed the title Support multiple external components per app [Apps] Support multiple external components per app Oct 19, 2019
@shiqimei shiqimei reopened this Oct 19, 2019
@shiqimei shiqimei requested a review from graywolf336 October 19, 2019 20:07
Copy link
Contributor

@graywolf336 graywolf336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, much nicer.

@shiqimei shiqimei merged commit 32eaee6 into RocketChat:lolimay-apps-engine-experimental Nov 11, 2019
@shiqimei shiqimei deleted the support-multiple-external-components-per-app branch November 11, 2019 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants