Fix: Correctly aligned input element of custom user status component#16151
Merged
ggazzo merged 3 commits intoRocketChat:developfrom Feb 20, 2020
ashwaniYDV:customstatus
Merged
Fix: Correctly aligned input element of custom user status component#16151ggazzo merged 3 commits intoRocketChat:developfrom ashwaniYDV:customstatus
ggazzo merged 3 commits intoRocketChat:developfrom
ashwaniYDV:customstatus
Conversation
Contributor
Author
|
@sampaiodiego I have fixed the stylelint issue. |
gabriellsh
requested changes
Jan 7, 2020
Member
gabriellsh
left a comment
gabriellsh
left a comment
There was a problem hiding this comment.
No need to create a new file or change anything, simply add <div class="rc-input__wrapper"> around the select element. (The wrapper applies the margins automatically). Also thanks for your constant contribution to the project! ;)
Contributor
Author
|
@gabriellsh I have made the requested changes. |
gabriellsh
approved these changes
Jan 8, 2020
ggazzo
changed the title
rodrigok
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16145
Description:
Used default value of margin used in different components to keep UI consistent.
Before fix:
After fix: