Remove users.info being called without need#16504
Merged
Conversation
ggazzo
approved these changes
Feb 6, 2020
gabriellsh
added a commit
to ritwizsinha/Rocket.Chat
that referenced
this pull request
Feb 13, 2020
…5997-ritwizsinha-15996 * 'develop' of github.com:RocketChat/Rocket.Chat: (181 commits) Update Livechat widget dependency version to 1.3.1. (RocketChat#16580) Update Apps-Engine version (RocketChat#16584) [FIX] Error when successfully joining room by invite link (RocketChat#16571) Add breaking notice regarding TLS (RocketChat#16575) [FIX] Invite links proxy URLs not working when using CDN (RocketChat#16581) Regression: Modal onSubmit (RocketChat#16556) Regression: UIkit input states (RocketChat#16552) [FIX] Do not stop on DM imports if one of users was not found (RocketChat#16547) [FIX] Introduce AppLivechatBridge.isOnlineAsync method (RocketChat#16467) Regression: UIKit missing select states: error/disabled (RocketChat#16540) [BREAK] Change apps/icon endpoint to return app's icon and use it to show on Ui Kit modal (RocketChat#16522) Regression: update package-lock (RocketChat#16528) Regression: Update Uikit (RocketChat#16515) Regression: UIKit - Send container info on block actions triggered on a message (RocketChat#16514) Use base64 for import files upload to prevent file corruption (RocketChat#16516) Regression: Ui Kit messaging issues RocketChat#16513 Regression: Send app info along with interaction payload to the UI (RocketChat#16511) Fix: License missing from manual register handler (RocketChat#16505) Exclude federated and app users from active user count (RocketChat#16489) Remove users.info being called without need (RocketChat#16504) ...
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The endpoint was being called when opening Members List without any arguments thus giving an error.
Related to #16495