You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds a new setting that allows defining a default Omnichannel department for SMS/WhatsApp integration.
So, if the setting is defined, all new incoming chats received through the SMS integration will be routed to the configured department.
In addition(CLOSESRocketChat/feature-requests#304), a new whatsApp feature will be supported: Inbound/Outbound location sharing.
Both agents and WhatsApp users will be able to share their locations, as displayed below:
Also, part of the code has been rewritten to make it simpler and more readable.
renatobecker
changed the title
[NEW] Allow to set default Omnichannel department for SMS/WhatsApp integration
[NEW] Allow to set default department and location sharing on SMS / WhatsApp integration
Mar 13, 2020
I think this pull request may be broking the other sms integration, since it's forcing the integration to declare an "extra" object inside returnData in the "parse" function. I'm currently developing a new integration for other sms/whatsapp service provider and it only works if latitude and longitude are declared.
I think it may be broking the other integrations (but I'm not sure) such as mobex and voxtelesys
I think this pull request may be broking the other sms integration, since it's forcing the integration to declare an "extra" object inside returnData in the "parse" function. I'm currently developing a new integration for other sms/whatsapp service provider and it only works if latitude and longitude are declared.
I think it may be broking the other integrations (but I'm not sure) such as mobex and voxtelesys
Thanks for point that out, I'll take a look at this case ASAP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new setting that allows defining a default Omnichannel department for SMS/WhatsApp integration.
So, if the setting is defined, all new incoming chats received through the
SMSintegration will be routed to the configured department.In addition(CLOSES RocketChat/feature-requests#304), a new
whatsAppfeature will be supported: Inbound/Outbound location sharing.Both agents and WhatsApp users will be able to share their locations, as displayed below:
Also, part of the code has been rewritten to make it simpler and more readable.