[NEW] Settings to enable E2E encryption for Private and Direct Rooms by default#16928
[NEW] Settings to enable E2E encryption for Private and Direct Rooms by default#16928sampaiodiego merged 6 commits intodevelopfrom
Conversation
|
This pull request introduces 2 alerts when merging 88ad339 into 4a14f44 - view on LGTM.com new alerts:
|
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
do you think GENERAL should be created using createRoom as well?
Rocket.Chat/server/startup/initialData.js
Line 15 in a102c6f
app/e2e/server/beforeCreateRoom.js
Outdated
| import { settings } from '../../settings'; | ||
|
|
||
| callbacks.add('beforeCreateRoom', ({ type, extraData }) => { | ||
| if (['d', 'p'].includes(type)) { |
There was a problem hiding this comment.
this test is kinda happening two times.. I think leaving only the if below makes more sense.
Co-Authored-By: Diego Sampaio <chinello@gmail.com>
Co-Authored-By: Diego Sampaio <chinello@gmail.com>
Co-Authored-By: Diego Sampaio <chinello@gmail.com>
…by-default # Conflicts: # app/meteor-accounts-saml/server/saml_server.js
|
This pull request introduces 2 alerts when merging edacf1a into 292a7c3 - view on LGTM.com new alerts:
|
|
Why this was merged when: a) It is still considered Beta b) It is still not supported on any of the mobile apps? I just don't get the logic of enforcing this by default when the code is not considered stable, and the apps have no support. Also noted that these probably still apply (for those who do not read documentation)
|
|
@reetp this is not enabled by default, but a setting to be able to enable it by default. There are some clients that want this feature since it doesn't hurt anyone we added the option. Yes, it's still in beta, it's not supported by our mobile apps yet, but if you need this and use only the web clients you may use this new setting. |
KK - sorry but the heading was not very clear.
Indeed
Yup. Thanks for the clarification. |
3 participants
No description provided.