[NEW] [Apps-Engine] New Livechat event handlers

[shiqimei]

This is the changes of the PR RocketChat/Rocket.Chat.Apps-engine#248 on the RocketChat side. Check issue RocketChat/Rocket.Chat.Apps-engine#234 for the details.

[shiqimei]

The app for testing:

import {
    IAppAccessors,
    IHttp,
    ILogger,
    IPersistence,
    IRead,
} from '@rocket.chat/apps-engine/definition/accessors';
import { App } from '@rocket.chat/apps-engine/definition/App';
import {  ILivechatAssignAgentHandler, ILivechatContext, ILivechatRoomClosedHandler, ILivechatRoomStartedHandler, ILivechatUnassignAgentHandler, ILivechatRoom } from '@rocket.chat/apps-engine/definition/livechat';
import { IAppInfo } from '@rocket.chat/apps-engine/definition/metadata';

export class LivechatTestingApp extends App implements ILivechatRoomStartedHandler, ILivechatRoomClosedHandler, ILivechatAssignAgentHandler, ILivechatUnassignAgentHandler {
    constructor(info: IAppInfo, logger: ILogger, accessors: IAppAccessors) {
        super(info, logger, accessors);
    }

    public async executeLivechatAssignAgentHandler(data: ILivechatContext, read: IRead, http: IHttp, persistence: IPersistence) {
        console.log('executeLivechatAssignAgentHandler', { data });
    }

    public async executeLivechatUnassignAgentHandler(data: ILivechatContext, read: IRead, http: IHttp, persistence: IPersistence) {
        console.log('executeLivechatUnassignAgentHandler', { data });
    }

    public async executeLivechatRoomStartedHandler(data: ILivechatRoom, read: IRead, http: IHttp, persistence: IPersistence) {
        console.log('executeLivechatRoomStartedHandler', { data });
    }

    public async executeLivechatRoomClosedHandler(data: ILivechatRoom, read: IRead, http: IHttp, persistence: IPersistence) {
        console.log('executeLivechatRoomClosedHandler', { data });
    }
}

[shiqimei]

Hey @renatobecker . I found that only the agent clicking the button return will call the RoutingManager.unassignAgent method ( thus triggering the LivechatUnassignAgent event). Is it by design? I think it should also trigger LivechatUnassignAgent event when someone forward the vistor to others. What do you think?

[renatobecker]

Hey @renatobecker . I found that only the agent clicking the button return will call the RoutingManager.unassignAgent method ( thus triggering the LivechatUnassignAgent event). Is it by design? I think it should also trigger LivechatUnassignAgent event when someone forward the vistor to others. What do you think?

Hi @lolimay!

Yeah, I got your point, but we can't rely on the RoutingManager.unassignAgent only.
My suggestion is to use the removeAgentFromSubscription to trigger the LivechatUnassignAgent event because it is called in the RoutingManager.unassignAgent, as well on the forwardRoomToAgent and the forwardRoomToDepartment. What do you think? This is exactly what you're expecting for.

Thanks.

[shiqimei]

Thanks @renatobecker ! It makes sense to me!

[shiqimei]

Hello @renatobecker ! It works well now during my local testing. Can you please help test it too? so that we can solve potential issues before merging it.