Skip to content

[FIX] Verification email body#17062

Merged
engelgabriel merged 3 commits intoRocketChat:developfrom
GOVINDDIXIT:fix-verification-email-desc
Mar 30, 2020
Merged

[FIX] Verification email body#17062
engelgabriel merged 3 commits intoRocketChat:developfrom
GOVINDDIXIT:fix-verification-email-desc

Conversation

@GOVINDDIXIT
Copy link
Contributor

@GOVINDDIXIT GOVINDDIXIT commented Mar 28, 2020

Closes #16911

@GOVINDDIXIT GOVINDDIXIT changed the title [FIX]: Verification email body [FIX] Verification email body Mar 28, 2020
@GOVINDDIXIT
Copy link
Contributor Author

GOVINDDIXIT commented Mar 28, 2020

@kaiiiiiiiii Any changes you want to suggest?

@kaiiiiiiiii
Copy link
Contributor

kaiiiiiiiii commented Mar 28, 2020

Yes, for sure, why not. I thought it’s obvious enough.

Imagine my sites name is “Google”.

“Welcome to Google, the best open source chat solution available today!”.

But my site isn’t the “best open source chat solution”, RocketChat is. My site is just based on that product.

I hope that clarifies my downvote.

@rodrigok
Copy link
Member

rodrigok commented Mar 28, 2020

I agree with @kaiiiiiiiii

@GOVINDDIXIT
Copy link
Contributor Author

GOVINDDIXIT commented Mar 28, 2020

@rodrigok I have updated the PR. Pls review

@melroy89
Copy link

melroy89 commented Mar 28, 2020

ps. there is something fundamentally wrong with the Build and Test / build-image-pr testcase. I saw the same issue within my own PR. Does somebody from the rocketchat devs fix this or?

@rodrigok
Copy link
Member

rodrigok commented Mar 28, 2020

@Danger89 it's normal, the CI doesn't provide the secrets when building PRs from forks, so the image build doesn't works for them since it requires a secret to upload the image.

@engelgabriel engelgabriel added this to the 3.1.0 milestone Mar 30, 2020
@engelgabriel engelgabriel merged commit 6935e49 into RocketChat:develop Mar 30, 2020
ggazzo added a commit that referenced this pull request Mar 30, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into feat…
c8e3a9c 
…/directory

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Check Omnichannel routing system before emitting queue changes (#17087)
  [FIX] Emit livechat events to instace only (#17086)
  [NEW] Add update method for user bridge (#17077)
  [FIX] Verification email body (#17062)
  Add User’s index for field `appId` (#17075)
  Fix omnichannel agent activity monitor (#16979)
@sampaiodiego sampaiodiego mentioned this pull request Apr 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@engelgabriel engelgabriel engelgabriel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.1.0

Development

Successfully merging this pull request may close these issues.

[BUG] Confusing verification email

5 participants

@GOVINDDIXIT @kaiiiiiiiii @rodrigok @melroy89 @engelgabriel

Comments