Skip to content

Regression: Broken Search if users without DM subscriptions are listed#17074

Merged
rodrigok merged 1 commit intodevelopfrom
fix/global-search
Mar 29, 2020
Merged

Regression: Broken Search if users without DM subscriptions are listed#17074
rodrigok merged 1 commit intodevelopfrom
fix/global-search

Conversation

@tassoevan
Copy link
Contributor

An error was thrown when getting the avatars and listing the chat room items of search results.

@tassoevan tassoevan added type: bug area: ui Touches the code on client side labels Mar 29, 2020
@tassoevan tassoevan added this to the 3.1.0 milestone Mar 29, 2020
@tassoevan tassoevan requested review from ggazzo and rodrigok March 29, 2020 19:54
@rodrigok rodrigok changed the title [FIX] Broken Search if users without DM subscriptions are listed Regression: Broken Search if users without DM subscriptions are listed Mar 29, 2020
@rodrigok rodrigok merged commit d83d6ca into develop Mar 29, 2020
@rodrigok rodrigok deleted the fix/global-search branch March 29, 2020 20:19
ggazzo added a commit that referenced this pull request Mar 30, 2020
…to feat/directory

* 'feat/directory' of github.com:RocketChat/Rocket.Chat:
  Add bio as default field for searching
  Remove topic column from users tab
  Featured on top always
  [NEW] Home button on sidebar (#17052)
  [IMPROVE] Repeat “Reply In Thread” and “Add Reaction” inside the message actions menu (#17073)
  Make DirectMessageRoomType.isGroupChat() accept null roomData (#17074)
  [IMPROVE] Tab Bar actions reorder (#17072)
  Regression: Overwrite model functions on EE only when license applied (#17061)
  Regression: users.setStatus throwing an error if message is empty (#17036)
  Regression: Omnichannel notification on new conversations displaying incorrect information (#16346)
@sampaiodiego sampaiodiego mentioned this pull request Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui Touches the code on client side type: bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments