Skip to content

Comments

Static props for Administration route components#17285

Merged
ggazzo merged 2 commits intodevelopfrom
fix/register-admin-route-props
Apr 13, 2020
Merged

Static props for Administration route components#17285
ggazzo merged 2 commits intodevelopfrom
fix/register-admin-route-props

Conversation

@tassoevan
Copy link
Contributor

Some distinct routes can render the same component but with different props. This PR enables it.

@tassoevan tassoevan added type: bug area: ui Touches the code on client side labels Apr 13, 2020
@tassoevan tassoevan added this to the 3.2.0 milestone Apr 13, 2020
@tassoevan tassoevan requested review from gabriellsh and ggazzo April 13, 2020 20:32
@ggazzo ggazzo changed the title [FIX] Static props for Administration route components Static props for Administration route components Apr 13, 2020
@ggazzo ggazzo merged commit c180a53 into develop Apr 13, 2020
@ggazzo ggazzo deleted the fix/register-admin-route-props branch April 13, 2020 20:57
gabriellsh added a commit that referenced this pull request Apr 14, 2020
…users_and_rooms

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] Omnichannel SMS / WhatsApp integration errors due to missing location data (#17288)
  [FIX] User search on directory not working correctly (#17299)
  [FIX] Can not save Unread Tray Icon Alert user preference (#16288) (#16313)
  [FIX] Variable rendering problem on Import recent history page (#15997)
  [FIX] Admin panel custom sounds, multiple sound playback fix and added single play/pause button (#16215)
  [FIX] Discussions created from inside DMs were not working (#17282)
  [FIX] translation for nl (#16742)
  [FIX] No maxlength defined for custom user status (#16534)
  [FIX] Directory users email sort button (#16606)
  [FIX] In Create a New Channel, input should be focused on channel name instead of invite users (#16405)
  [FIX] Email not verified message (#16236)
  [FIX] Directory default tab (#17283)
  Update ru.i18n.json (#16869)
  [FIX] Avatar on sidebar when showing real names (#17286)
  Update Apps-Engine to stable version (#17287)
  [NEW][ENTERPRISE] Auto close abandoned Omnichannel rooms (#17055)
  Static props for Administration route components (#17285)
  [NEW] Default favorite channels (#16025)
  Apply $and helper to message template (#17280)
@sampaiodiego sampaiodiego mentioned this pull request Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui Touches the code on client side type: bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants