Skip to content

Comments

[IMPROVE] Unused styles#17554

Merged
ggazzo merged 27 commits intodevelopfrom
perf/unused-css
May 15, 2020
Merged

[IMPROVE] Unused styles#17554
ggazzo merged 27 commits intodevelopfrom
perf/unused-css

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented May 6, 2020

  • Compiles LESS expressions on client-side instead of requesting it on server
  • Removes tests referring to obsolete class names
  • Removes unreferenced CSS rules
  • Extracts theme settings from variables.css
  • Updates the CSS custom properties' polyfill for IE11

@tassoevan tassoevan added area: ui Touches the code on client side type: improvement labels May 6, 2020
@tassoevan tassoevan added this to the 3.3.0 milestone May 6, 2020
@tassoevan tassoevan requested review from a team and sampaiodiego May 6, 2020 20:11
@tassoevan tassoevan changed the title [IMPROVE] Unused styles [BREAK] [IMPROVE] Unused styles May 8, 2020
@tassoevan tassoevan changed the title [BREAK] [IMPROVE] Unused styles [BREAK] [IMPROVE] Unused styles and legacy theme variables May 8, 2020
@tassoevan tassoevan changed the title [BREAK] [IMPROVE] Unused styles and legacy theme variables [BREAK] [IMPROVE] Unused styles May 8, 2020
@tassoevan tassoevan changed the title [BREAK] [IMPROVE] Unused styles [IMPROVE] Unused styles May 9, 2020
@tassoevan tassoevan marked this pull request as ready for review May 15, 2020 16:23
ggazzo
ggazzo previously approved these changes May 15, 2020
@ggazzo ggazzo changed the base branch from develop to admin-refactor May 15, 2020 16:50
@ggazzo ggazzo changed the base branch from admin-refactor to develop May 15, 2020 16:51
@ggazzo ggazzo dismissed their stale review May 15, 2020 16:51

The base branch was changed.

@ggazzo ggazzo merged commit 811688e into develop May 15, 2020
@ggazzo ggazzo deleted the perf/unused-css branch May 15, 2020 16:53
ggazzo added a commit that referenced this pull request May 15, 2020
…n-refactor

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [IMPROVE] Unused styles (#17554)
ggazzo added a commit that referenced this pull request May 15, 2020
…/new-threads

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Pressing enter on search reloads the page - admin pages (#17663)
  [NEW] Admin refactor  Second phase (#17551)
  [IMPROVE] Unused styles (#17554)
  [FIX] Directory search user placeholder (#17652)
  [NEW] Added "Add custom emoji" link to emoji picker (#16250)
  [FIX] Marketplace tiered pricing plan wording (#17644)
  [FIX] Secret Registration not properly validating Invite Token (#17618)
  Improve: New PR Template (#16968)
  Add engine versions for houston with templates (#17403)
  Use Users.findOneByAppId instead of querying directly (#16480)
  Remove unnecessary setting redefinition (#17587)
  Deprecate compatibility cordova setting (#17586)
ggazzo added a commit that referenced this pull request May 16, 2020
* 'develop' of github.com:RocketChat/Rocket.Chat: (25 commits)
  [FIX] Not redirecting to `First Channel After Login` on register (#17664)
  Regression: Pressing enter on search reloads the page - admin pages (#17663)
  [NEW] Admin refactor  Second phase (#17551)
  [IMPROVE] Unused styles (#17554)
  [FIX] Directory search user placeholder (#17652)
  [NEW] Added "Add custom emoji" link to emoji picker (#16250)
  [FIX] Marketplace tiered pricing plan wording (#17644)
  [FIX] Secret Registration not properly validating Invite Token (#17618)
  Improve: New PR Template (#16968)
  Add engine versions for houston with templates (#17403)
  Use Users.findOneByAppId instead of querying directly (#16480)
  Remove unnecessary setting redefinition (#17587)
  Deprecate compatibility cordova setting (#17586)
  Hyper.sh went out of business in early 2019 (#17622)
  [NEW] Add Permissions to deal with Omnichannel visitor past chats history (#17580)
  [NEW] Add permissions to deal with Omnichannel custom fields (#17567)
  [FIX] Livechat iframe allow microphone and camera (#9956)
  [FIX] Do not allow passwords on private channels (#15642)
  [FIX] Mail Messages > Cannot mail own user. (#17625)
  [FIX] remove multiple options from dontAskMeAgain (#17514)
  ...
This was referenced May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui Touches the code on client side type: improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants