Regression: Set retryWrites=false as default Mongo options#17683
Merged
sampaiodiego merged 1 commit intodevelopfrom May 19, 2020
Merged
Regression: Set retryWrites=false as default Mongo options#17683sampaiodiego merged 1 commit intodevelopfrom
sampaiodiego merged 1 commit intodevelopfrom
Conversation
geekgonecrazy
approved these changes
May 19, 2020
Contributor
geekgonecrazy
left a comment
geekgonecrazy
left a comment
There was a problem hiding this comment.
Thanks for saving the day! :) This would have been a major headache :)
gabriellsh
added a commit
that referenced
this pull request
May 19, 2020
…customFields_users * 'develop' of github.com:RocketChat/Rocket.Chat: [IMPROVE] Add env var to configure Chatpal URL and remove it from beta (#16665) Regression: Set retryWrites=false as default Mongo options (#17683) Fix the leak of agent's custom fields. (#17640) Regression: removed avatar provider temporary [FIX] Avatar url provider ignoring subfolders (#17675) [IMPROVE] Added divider between tables and paginations (#17680) [IMPROVE] Starred Messages (#17685) Regression: status-color-online (#17684)
gabriellsh
added a commit
that referenced
this pull request
May 22, 2020
…apps_rewrite * 'develop' of github.com:RocketChat/Rocket.Chat: Regression: Integrations edit/history crashing (#17702) [FIX] Allow owners to react inside broadcast channels (#17687) Regression: User edit form missing fields (#17699) [FIX] Default filters on Omnichannel Current Chats screen not showing on first load (#17522) Update Helper.js (#17700) [FIX] UI KIT Modal Width (#17697) Update Contributing Guide (#17653) LingoHub based on develop (#17693) [NEW] Added custom fields to Add/Edit user (#17681) Regression: Fix incorrect imports of the Apps-Engine (#17695) Improve: Remove uncessary RegExp query by email (#17654) [NEW] [Apps-Engine] New Room events (#17487) [IMPROVE] Add env var to configure Chatpal URL and remove it from beta (#16665) Regression: Set retryWrites=false as default Mongo options (#17683)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
When we updated to Meteor 1.10.x, Mongo npm package has updated to version 3.2 which is then using
retryWrites: trueas default.This PR forces the option value to stay as it previously default value, which is
false, as it would probably be a breaking change becauseretryWritesis support only by WiredTiger.How to test or reproduce
Screenshots
Types of changes
Checklist
Changelog
Further comments
MongoDB docs https://docs.mongodb.com/manual/core/retryable-writes/#enabling-retryable-writes