Merged
Conversation
merging Rocket.Chat current master
This is a work in progress of Rocket.Chat RTL Support. The work is not finished. I didn't know where to put the .rtl class in the html file, so I use the addClass method in layout.coffee. Please write down suggestion and don't accept this pull request yet, until final version.
Contributor
Author
shahar3012
changed the title
shahar3012
changed the title
Member
|
Looking good! The place where you added the .rlt support seem right, it just need a logic test to check if the user is using a rtl locale? |
Contributor
Author
|
I think so. I suggested earlier that the layout change should be based on the language, and that the language can be changed from the settings section. |
This is a work in progress of the RTL Support. It includes several update to the input and textarea elements that aren't yet supported both RTL and LRT writing (using `dir="auto"`).
Contributor
Author
|
I've commited a several changes mostly to the side-nav elements and some input and textarea elements that aren't yet supported both RTL and LTR. |
Member
|
Seem all good. Should I merge it now and create the language selection option? |
Contributor
Author
|
You can. I think it's good enough. The language selection option is mandatory! :) |
engelgabriel
added a commit
that referenced
this pull request
Jun 14, 2015
RTL Support - I just need to create the language selector now.
HappyTobi
pushed a commit
to HappyTobi/Rocket.Chat
that referenced
this pull request
Jul 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work in progress of Rocket.Chat RTL Support. The work is not finished. I didn't know where to put the .rtl class in the html file, so I use the addClass method in layout.coffee. Please write down suggestions to cover all the missing elements that need to be supported and don't accept this pull request yet, until final version.