UserPresence.start() is called twice#182
Closed
rockhouse wants to merge 1 commit intoRocketChat:masterfrom
rockhouse:double_UserPresenceStart
Closed
UserPresence.start() is called twice#182rockhouse wants to merge 1 commit intoRocketChat:masterfrom rockhouse:double_UserPresenceStart
rockhouse wants to merge 1 commit intoRocketChat:masterfrom
rockhouse:double_UserPresenceStart
Conversation
once in presence.coffee and once in startup.coffee nothing big but I guess we need just one call right?
Member
|
Actually, since one code runs on server and another on client, it's not called twice. I'm not sure if to call |
Contributor
Author
|
You are right, my bad, indeed both are needed! |
Peym4n
pushed a commit
to redlink-gmbh/Rocket.Chat
that referenced
this pull request
Jan 17, 2018
Shailesh351
pushed a commit
to Shailesh351/Rocket.Chat
that referenced
this pull request
Mar 18, 2020
Fix jump to message in mobile view
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method UserPresence.start() is called twice within Meteor.startup once in presence.coffee and once in startup.coffee nothing big but I guess we need just one call right?