Skip to content

Comments

[FIX] #19237 - Translations for select setting in App Setting#19238

Closed
murtaza98 wants to merge 4 commits intoRocketChat:developfrom
murtaza98:fix-apps-setting-select-translations
Closed

[FIX] #19237 - Translations for select setting in App Setting#19238
murtaza98 wants to merge 4 commits intoRocketChat:developfrom
murtaza98:fix-apps-setting-select-translations

Conversation

@murtaza98
Copy link
Contributor

@murtaza98 murtaza98 commented Oct 13, 2020

Proposed changes

Issue(s)

Fixes #19237

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@d-gubert d-gubert added this to the 3.8.0 milestone Oct 15, 2020
@d-gubert
Copy link
Member

Hey @murtaza98 ! This change doesn't require modifications in the Apps-Engine?

@murtaza98
Copy link
Contributor Author

Hey @d-gubert Nopes. Translation are handled on core so no changes to apps engine will be required 😁

@d-gubert
Copy link
Member

Ok! Can you provide an example of what the settings config in the app would look like for this to work?

@murtaza98
Copy link
Contributor Author

murtaza98 commented Oct 19, 2020

Hi @d-gubert Here is a sample app zip file. Hope it helps u to understand the bug i was facing. Thanks
multi-select-translations-sample_0.0.1.zip

Btw, Sorry for the delay 🙈

@d-gubert d-gubert self-requested a review October 20, 2020 15:21
Copy link
Contributor

@shiqimei shiqimei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall 👍

@murtaza98
Copy link
Contributor Author

Closing in favour of #23908

@murtaza98 murtaza98 closed this Dec 9, 2021
@sampaiodiego sampaiodiego mentioned this pull request Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Translations not working for Apps Select Fields

3 participants