[FIX] #19237 - Translations for select setting in App Setting#19238
Closed
murtaza98 wants to merge 4 commits intoRocketChat:developfrom
murtaza98:fix-apps-setting-select-translations
Closed
[FIX] #19237 - Translations for select setting in App Setting#19238murtaza98 wants to merge 4 commits intoRocketChat:developfrom murtaza98:fix-apps-setting-select-translations
murtaza98 wants to merge 4 commits intoRocketChat:developfrom
murtaza98:fix-apps-setting-select-translations
Conversation
Member
|
Hey @murtaza98 ! This change doesn't require modifications in the Apps-Engine? |
Contributor
Author
|
Hey @d-gubert Nopes. Translation are handled on core so no changes to apps engine will be required 😁 |
Member
|
Ok! Can you provide an example of what the settings config in the app would look like for this to work? |
Contributor
Author
|
Hi @d-gubert Here is a sample app zip file. Hope it helps u to understand the bug i was facing. Thanks Btw, Sorry for the delay 🙈 |
Co-authored-by: Shiqi Mei <shiqi.mei@lolimay.cn>
d-gubert
approved these changes
Oct 27, 2020
Contributor
Author
|
Closing in favour of #23908 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue(s)
Fixes #19237
How to test or reproduce
Screenshots
Types of changes
Checklist
Changelog
Further comments