Skip to content

Release 3.6.3#19243

Closed
mrsimpson wants to merge 586 commits intoRocketChat:developfrom
assistify:release/3.6.3
Closed

Release 3.6.3#19243
mrsimpson wants to merge 586 commits intoRocketChat:developfrom
assistify:release/3.6.3

Conversation

@mrsimpson
Copy link
Contributor

This brings the latest state tested on develop to production.

@lgtm-com
Copy link

lgtm-com bot commented Oct 14, 2020

This pull request introduces 3 alerts when merging 650c65f into de13028 - view on LGTM.com

new alerts:

  • 2 for Useless regular-expression character escape
  • 1 for Useless assignment to local variable

@mrsimpson
Copy link
Contributor Author

I compared with the standard 3.6.3 version and found the following major diff:

Imho, this after all looks good to me. We should create a PR and remove the unnecessary diff. I'd recommend to however do this on developand ship it with the next release.

@mrsimpson
Copy link
Contributor Author

wrong repo

@mrsimpson mrsimpson closed this Oct 14, 2020
@lgtm-com
Copy link

lgtm-com bot commented Oct 14, 2020

This pull request introduces 3 alerts when merging 4c7b89b into de13028 - view on LGTM.com

new alerts:

  • 2 for Useless regular-expression character escape
  • 1 for Useless assignment to local variable

@mrsimpson mrsimpson deleted the release/3.6.3 branch October 14, 2020 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments